-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal on the extension of the V1 proof sector lifetime #56
Comments
This is a good proposal. If V1 proof sectors can't be extended, many sealing machine resources will be wasted to seal sectors again. Filecoin should be a project with less energy consumed, then it will be more competitive in storage markets. |
If a huge number of sectors can't be extended, there will be several side effects. If the miners seal sectors again, it will take much more time, and much more gas. More messages will make the chain congested, and other miners will pay more high gas fees, too. |
Totally agree to extend life cycle of v1 proof sectors. |
If the purpose is for better storage market, instead of extend, it should be upgrade sectors with data deals, otherwise those sectors are useless in storage market. |
This is definitely a good suggestion for network development. At present, the high gas cost is due to the congestion of message pool. If V1 sector cannot be extended life cycle will lead to quite a number of re-sealing, which will bring a new round of congestion peak, that is not conducive to the reduction of gas cost, but also bring pressure (can be avoidable, just extend life cycle) to the network. |
@deltazxm good proposal to discuss. I would suggest adding a Motivation section and a Security Consideration section. The motivation is clear that there are half (possibly more) of power are sealed using V1, and massive computing resources consumed for that. To allow the extension of V1 sectors is environment friendly way to keep the power of Filecoin. In addition, it is also good to maintain Filecoin's stability. However, there might be security concerns, which is not very clear to many miners. To me, I could understand why upgrading from V1 to 1.1 for security issue, but it is more impact on the sealing process, but how's its impact to verification. @nicola may add more to this. |
If impact to verification.Then the current v1 sector also has security problem.So,I think there is no problem with windowPOST. |
This is by design, motivated by security considerations for the V1 proof. |
this is just not true. this would imply that right now sectors are not being sealed because of existing v1 sectors. if those sectors expire the baseline will change, that's the first thing. and then resources that would be used for sealing anyways would be used to "reseal" those sectors. i doubt that there will be an overall increase in CC sector sealing activity if we just let those sectors expire. |
"reseal" still take much collaterals and gas? ? |
1 similar comment
"reseal" still take much collaterals and gas? ? |
reseal here means sealing other sectors to replace them. you have to keep in mind that collateral and fees for most, if not all, v1 sectors were paid with testnet FIL - at a market price of exactly 0. so no one ever paid for them. the reason that this issue exists is not to protect the network or keep the baseFee low - but to go on earning real FIL with sectors that were paid for with testnet FIL - and as you can imagine they have a way higher ROI than sectors that needed to be sealed with real FIL. |
All sectors before November 26 have this problem.Not only SR. |
Sectors are meant to expire. Miners cannot control the length of time a client makes a deal for. There is no reason to extend these sectors. We will all lose power, yes, that is how the system is designed. |
I don't think it's good idea extend life cycle of v1 proof sectors. A lot of v1 sectors are SP1 sectors, some of them are not stable and it should be termination for secure reason. |
what kind of "not stable"? |
The rewards obtained in the testnet are used to pay those miners who have made great contributions to Filecoin. They are willing to follow Filecoin when the mainnet is uncertain, and spend a lot of time and money on machines, labor costs, operation and maintenance. , Laid the foundation for the successful launch of the mainnet, so the testnet coin is surely valuable. Now these sectors cannot be extended, it means that it will cost 150% more pledge cost and gas to reseal it. This is unnecessary and unreasonable. No one has specifically explained why it has affected the security and stability of the mainnet. Should such a decision on a decentralized network not be more cautious in soliciting community suggestions? |
neither pledge nor sealing costs of these sectors were part of the rewards. the testnet coin shouldn't have had any value at all. not then, not now, not ever.
not "now" - they never were able to be extended later.
we cannot cement this inequality forever on the chain. the stability will suffer. cannot talk about security - i assume that if there are issues no one will tell you, for obvious reasons and we just let them phase out. |
Sectors before November 24 will not to be extended, but between October 15 and November 24, we have purchased a large amount of real coins to seal data, these r "real" sectors! why these sectors will now also be "killed"? |
Agree. At least sectors between Oct 15 and Nov 24 should be extended. |
It was not a good idea to shift the SP1 sector to the mainnet at that time. These sectors should be expired. It's not fair to the new miners. Now that big miners have more and more advantages, new miners have to spend more to join the network. This is not conducive to decentralization. |
The life cycle of these v1 sectors should not be extended in order to increase the profits of big miners. They have acquired a lot. There should be more opportunities for new miners and small miners to join the network. |
At least sectors between Oct 15 and Nov 24 should be extended. |
At least sectors between Oct 15 and Nov 24 should be extended. |
The only strong reason for objection of extension is security problem, what is that? Is it that the bug in previous proof makes it proving faster? I would believe that is still safe for years before the hardware power is improved significantly for tens of times. If the concern is about related to this, how about allowing one time for perhaps one or two years? Or any other one not unveiled? |
I wrote a comment here a while ago: filecoin-project/specs-actors#1309 (comment)
**: note that Filecoin will still be secured by the collateral of these sectors |
So the conclusion will not be extension?There are different voices in the community.We want extension the sector.At least sectors between Oct 15 and Nov 24. @nicola |
Oct 5 ~ Nov 24 ? |
Yes,After mainnet |
if keep the power between Oct 5 ~ Nov 24, does that mean only the sectors before this period is insecure? No ,if you want to keep , keep all of them, if it is expired due to security, expired all of them. |
V1 proof sectors deserve extension. First, these V1 proof sectors are not "free", there are thousands of servers maintaining them (I doubt the intentions of those ones who are not supporting this proposal, early miners put in money and time before others doing so to build filecoin system and don't deserve a fair sector? ). Secondly, the large fluctuation of storage volume itself is a security risk to the filecoin network. In the end, what we are pursuing is a larger scale of storage and a moving forward consensus. Giving the V1 proof sectors extension they deserve and let the community put the eyes on the future. |
Only if fairness is not important in the community and system, then big miners will take over the right to speak. It's harmful to the community and the whole ecosystem of filecoin. |
Allow v1 sectors to have 540 days in epoch as max sector life time was proposed in fip-0014 as one of the options to this topic. The proposal is still in DRAFT and the community should work on the |
there is still no argument for how this improves the network. if letting these sectors expire now, as some say here, will create problems - how are these problems different in now+x days? except adding to the risk of these sectors being "broken" by hardware/software implementations this FIP is doing nothing of value for the network. |
i am sorry, but that is not an argument. why should we keep a security risk (for all people involved!!!) on the chain for the "benefit" of a few miners? to make the network more secure for everyone we should terminate these sectors forcefully as soon as possible. keeping them longer then necessary (and to be straight forward here: no one needs those sectors! they are just "another sector"... can be replaced with new ones at all times) is not fair to everyone involved with filecoin, we deserve security risks to be eliminated as soon as they are known! |
V1 proof sectors are not free, especially between Oct 15 and Nov 24. Miners who spent a lot of FILs to pledge between Oct 15 and Nov 24 will be long term players and the most loyal supporters of the Filecoin ecosystem, since they were willing to invest real money in a project just started. |
here are the arguments i see so far pro/contra implementing this FIP. pro implementing:
contra implementing:
there is no argument so far how implementing this would improve filecoin - in my eyes. |
letting these sectors expire will attract more miners - i am sure about that. the overall power will shrink, allowing new miners/miners without (a lot of) v1 sectors to get a bigger share of the overall power (i know - to not let that happen is the purpose of this FIP), possibly creating a more balanced miner landscape, expanding decentralization and in the end benefit the whole network. |
I'd emphasizes two things here for further discussion:
|
FIP0014 not only satisfies the need for arrangement, but also does not lose fairness. It is a perfect progress that everyone can accept. We hope it can be implemented as soon as possible. @jennijuju |
Since these sectors are using V1. To avoid a security risk for the whole network, letting them expire is the best solution from my opinion. So I object the extension of the V1 sector life cycle. |
@f8-ptrk, I think part of the problem may stem from the fact that core team made the decision of not extending V1 proof sectors pretty much silently. Decisions that may affect that many miners should at least go through some level of discussion. If the core team hadn't made any sector policy changes, then you can see this fip as improvement of network security. |
I don’t think it’s fair to the new miners. I worked with them, they complained that the early big miners had so many cheap sectors that it became more difficult for them to participants on the network. This may not be conducive to decentralization. |
I think preference from a protocol perspective is still to enable an easy way to upgrade and reseal v1 sectors into v1.1 sectors so they have the same storage power security guarantees, but don't have to take up chain space (and gas/collateral fees) again. Given this isn't ready for the sectors expiring in the next few months, I think the lotus team is somewhat agnostic about whether the community should allow 6 month sectors to share the 540 day expiry (that is the default for all new sectors) or expire now. The security concerns here absolutely mean these sectors should not be renewed past that 540 day limit - but the level of concern is the same for all v1 sectors (most of which are 540 day sectors, not 180 day sectors). Slight preference to "expire now" since that's the easiest and avoids another state upgrade in the next few weeks - but OK with either of these two options. For deciding between those options, maybe we can use the new https://filpoll.io tool to collect community sentiment across miners / token holders / clients / etc. Thoughts on that? I absolutely expect the v1 sector expiration to be a concern again in a year - and it will not be an option to extend v1 sectors without resealing at that time due to security concerns. In preparation for that, I think community members like @steven004 @deltazxm @coder-lb @maobisheng etc should help identify / implement the best path to upgrade v1 sectors into v1.1 sectors if maintaining power and minimizing chain overhead/fees is desired. |
Agreed, @momack2 . |
Hope to start the poll as soon as possible. @jennijuju.Once the conclusion is reached, publish the conclusion as soon as possible. This issue has been discussed for a long time. |
Hoping to start the poll tomorrow! |
How to initiate a poll |
It will be setup and announced to the community later today. |
The Impact of V1 Sector Expirations on Filecoin Storage and CryptoeconomicsBackground contextShortly after Filecoin liftoff, a security issue was reported with the v1 proofs. The issue was fixed in v1.1 proofs, which were introduced in the Filecoin network version 7 upgrade, on November 25th, 2020. As a result of this upgrade:
Since the security of these sectors is not critically compromised, we can consider allowing their extension, which was proposed in FIP-0014. This report details the storage and cryptoeconomic impacts of allowing vs. rejecting FIP-0014. Executive Summary
The code and the visualizations for this writing can be seen on the following link: https://blockscience.github.io/filecoin-metrics/notebooks/fip_0014.html The first wave of expiring sectorsRight now, Filecoin has about 92.3M active sectors, on which 26.2M (28% of the total) uses the V1 proof. An immediate concern about them is about the sectors with 6 months lifetimes, as they're starting to expire on March 26, 2021, although the majority is going to expire between 22 April, 2021 and 28 May, 2021, peaking on 10 May, 2021. That first wave makes up 6.3% of all Filecoin active sectors, or 22.3% of all V1 sectors. In absolute terms, they're 5.8M sectors, or about 177PiB over three months. The big picture is contained in the following chart, where waves related to the 6 months, 12 months and 18 months sectors for both V1 and V2+ sectors are identified: A more granular view is obtained by getting the count on a daily window before 15 June. Note that the vertical axis is on logarithm scale. Through the above figures, we can define key dates in regards to daily sector expiration rate:
Impact on Growth trends & Storage PowerThe current forecast points towards having 3.8 EiB of raw-byte storage power by the end of May. This is fuelled by the continued sealing of new sectors. We project that the daily new sectors growth will be between 450k per day and 900k per day, generating a daily SP growth between 13.7 PiB per day to 27.5 PiB per day. The expiration of approximately 5.8M sectors between 22 April and 28 May will subtract 180k per day (5.5 PiB per day) from the above numbers, which is equivalent to a reduction of 40% on the pessimistic side and 20% on the optimistic side. Note that with more 64GiB sectors being added to the network, the actual impact tends towards the more optimistic case. Impact on CollateralRight now, Filecoin has 27.8 Million FIL locked as sector collateral, 5.8M (21%) of which are on the V1 sectors. Notice this is relatively lower than the sector share, as the collateral for each new sector tends to increase with time. The 6 months V1 sectors have 1.2M FIL locked with them (4.3% of the network total), and the event of their droppage should not be an issue for network security. ConclusionsFrom a Cryptoeconomics point of view, the network will continue to be safe and healthy on any decision regarding allowing all V1 sectors to be extended to a maxium 540 days in epoch lifetime from their activation epoch. The decision of letting the V1 sectors expiring or not is to be put before the community, as there are multiple angles to FIP-0014 approval, which include considerations regarding fairness and behaviour incentivation, as well as other ones like environmental and waste minimization. |
This is very informative @danlessa - thank you! |
Storage miners can vote on whether to adopt this FIP here! |
Answering everything with policy, why are you going to change the policy this time? |
Core devs have reviewed the FIP-0014 survey result and final security audit, and have decided that FIP-0014 will be accepted in the network. Network upgrade epoch and implementation release timelines will be announced in the Network Updates later today. |
Network upgrade timeline filecoin-project/community#74 (comment) |
Summary
It is currently not possible to extend the life cycle of the V1 proof sectors. This has caused a huge loss to the miners who sealed the V1 proof sectors in early days. Sealed sectors should only take windowPoSt challenges, security issues would not be involved. So we propose the V1 proof sectors' life cycle could be extended.
If the life cycle of these sectors cannot be extended, there will be a lot of sealing computation resources wasted to seal these sectors again. If miners have to seal sectors again, it will take much more collaterals and gas. More messages will make the chain congested, and other miners will have to pay more high gas fees too.
If the life cycle of V1 proof sectors is set to 180 days, miners would experience horrible loss and may cause even greater losses due to gas fee issues.
Improvement Goal
Allow the life cycle of V1 proof sectors to be able to extend like v8 proof sectors. Please see the detailed improvement plan: [https://github.com/filecoin-project/specs-actors/pull/1310]
The text was updated successfully, but these errors were encountered: