Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Worker code again #243

Open
vmx opened this issue Dec 9, 2021 · 0 comments
Open

Review Worker code again #243

vmx opened this issue Dec 9, 2021 · 0 comments

Comments

@vmx
Copy link

vmx commented Dec 9, 2021

As part of my work of moving FFT and Multiexp into the ec-gpu project, I was reviewing the Worker code again.

The current Worker::scoped() code seems to do what the comment says. Though it seems to needlessly use a message passing primitive.

THREAD_POOL.scoped(), where THREAD_POOL is a yastl pool, hence it's call to Pool::scoped(), which according to it's docs is already waiting for the execution to finish before it returns. This means the additional message passing wouldn't be needed.

So either change the call to the pool to Pool::spawn(), which wouldn't wait for the execution to finish, or we remove the message passing. As we want it to block, I suggest we keep relying on Pool::scope().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant