Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fp::from_bytes_le #4

Closed
dot-asm opened this issue Aug 22, 2020 · 1 comment
Closed

Fp::from_bytes_le #4

dot-asm opened this issue Aug 22, 2020 · 1 comment

Comments

@dot-asm
Copy link

dot-asm commented Aug 22, 2020

https://github.com/dignifiedquire/blstrs/blob/df8c49dbe3f1621ff10c393691cbd59358c29bb2/src/fp.rs#L808-L815

Doesn't straight bytes.as_ptr() work? And I don't follow raw.try_into().ok().

Same applies to from_bytes_be... And to_bytes, modulo out.as_mut_ptr()...
@dignifiedquire
Copy link
Contributor

yes as_ptr() works fine for arrays, I am not sure how I didn't get this the first time around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dignifiedquire @dot-asm