-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed blst version #46
Comments
this is on purpose, as blst releases sometimes contain breaking changes in patch releases and we have been burnt by this before |
Thanks. Then I guess I will have to fork this or that dependency and try to patch it. It might work but it's a bit of a maintenance nightmare, and I can miss crucial updates. Perhaps, since v0.6.0 depends on =0.3.10, it would be possible to also release a newer version v0.5.1 that allows a range you are comfortable with, say, between 0.3.9-0.3.10, so anything that depends on 0.5.0 can be safely upgraded to 0.5.1 and allow cargo to resolve the dependency hell? |
I forked the projects and made new branches to try until I found a combo that worked (with my current dependencies at least). I would open PRs but there are no
And similarly in
For me it looks like blstrs:v0.4.3 with bls-signatures:v0.11.4 works against a dependency that needs blst:0.3.10 |
@aakoshh sorry, I forgot to open filecoin-project/bls-signatures#55. With this PR you should be able to update everything to their latest versions. |
Thanks @vmx! I checked and at least one more domino that I see you kindly maintain is |
And probably the filecoin-proofs-api as well. This is the chain I get when I tried to upgrade Forest from 11.0 to 12.0 (which I don't know if it's safe to do as it's a major version change):
I can't just patch |
@aakoshh do you need to upgrade to the latest |
In my case I couldn't use Instead what I did was to go back to the earliest But I do wonder if these Anyway, I'm unblocked now, although probably this will happen again and again. |
Thanks for the explanation! At least it's good to hear that the upgrade to Though usually, things should work out, which is the reason I do breaking releases. Usually all Filecoin related dependencies are taken care of and should end up with the same |
All dependencies should be on |
The version of the
blst
dependency is always fixed to exactly match a specific version, like here.Is that a true requirement, or was the
=
left in by accident? It makes it difficult to use libraries built on this one with something else that requires a higher patch version. For examplev0.5.0
wants=0.3.9
, but another dependency I have wants0.3.10
ofblst
. Ifblstrs
was happy with0.3.9
without=
thecargo
should be able to pick the higher version.The text was updated successfully, but these errors were encountered: