Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Fp6 be part of the public API? #9

Closed
dot-asm opened this issue Aug 22, 2020 · 4 comments
Closed

Should Fp6 be part of the public API? #9

dot-asm opened this issue Aug 22, 2020 · 4 comments

Comments

@dot-asm
Copy link

dot-asm commented Aug 22, 2020

What prevents you from omitting fp6.rs?

@dignifiedquire
Copy link
Contributor

Good question, I mostly added it to match the previous implementation as close as possible, but now that I am looking at the usage, nothing seems to ever use Fp6 outside of the internals.

@dignifiedquire dignifiedquire changed the title fp6.rs Should Fp6 be part of the public API Aug 24, 2020
@dignifiedquire dignifiedquire changed the title Should Fp6 be part of the public API Should Fp6 be part of the public API? Aug 24, 2020
@dot-asm
Copy link
Author

dot-asm commented Aug 24, 2020

nothing seems to ever use Fp6 outside of the internals

Right. The fp6 is just a detail of fp12 implementation. And actually so are fp and fp2. It's just that fp and fp2 are used even in point arithmetic...

@dot-asm
Copy link
Author

dot-asm commented Aug 27, 2020

The fp6 is just a detail of fp12 implementation. And actually so are fp and fp2. It's just that fp and fp2 are used even in point arithmetic...

Meaning that if point interface is sufficient for application purposes (or can be complemented to be sufficient), one can as well omit fp and fp2.

@dignifiedquire
Copy link
Contributor

I will leave it for the moment, might revisit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants