AlwaysKeepUnsealedCopy = false is not being honored.

[Reiers]

Checklist

• This is not a question or a support request. If you have any boost related questions, please ask in the discussion forum.
• This is not a new feature or enhancement request. If it is, please open a new idea discussion instead. New feature and enhancement requests would be entertained by the boost team after a thorough discussion only.
• I have searched on the issue tracker and the discussion forum, and there is no existing related issue or discussion.
• I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
• I did not make any code changes to boost.

Boost component

• boost daemon - storage providers
• boost client
• boost UI
• boost data-transfer
• boost index-provider
• Other

Boost Version

boost version 1.5.0+git.dbedffb

Describe the Bug

Hi Boost team 👋

After looking at logs, testing, talking with clients etc. in regards to issue filecoin-project/lotus#9396
(Snap Deals always creates an unsealed copy even though "AlwaysKeepUnsealedCopy = false")

We think we have found the reason for why AlwaysKeepUnsealedCopy = false is not being honored:

boost/storagemarket/provider.go

Line 591 in 3c68f89

//KeepUnsealed: deal.FastRetrieval,

Not all SP's or clients wants fast retrieval and should be able to opt out.

Logging Information

lotus-miner storage find 16273
In FILECOIN_SERVER (Unsealed, Cache, Update, UpdateCache)
	Sealing: false; Storage: true
	Local (/nfs/TechHedgeUnit3)
	URL: http://192.168.10.80:8001/remote/unsealed/s-t022352-16273 <---

Repo Steps

1. Check that your configuration on the lotus miner is correct.
2. Run lotus-miner sectors snap-up <sectornumb>
3. Send a deal, import and seal deal into the snapped up sector
4. See that an unsealed copy was created in the long term storage.

[jacobheun]

Nice find! Yes, we should definitely fix this.

Context: Archival/disaster recovery is a very real use case. I as a client might say, "I probably won't ever need this data, if I do, I'll contact you". We could make this easier in the future with a nice unseal cost story, but we should ensure support for the manual version works in the interim.