Add transaction insight for FilForwarder transactions #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a transaction insight tab for FilForwarder transactions (0x to f1 FIL transfer) to MetaMask:
Currently MetaMask Flask will show the empty tab by default for non-FilForwarder transactions as well:
This is a bug that the MetaMask team is addressing.
We initially wanted to make it dynamically configurable by the user whether the transaction insights is enabled as a workaround for this bug. This is not possible unfortunately, as the empty tab will still show as long as the transaction insight permission is requested by the snap and requesting that permission must be done when the snap is installed.
Type of change
Please delete options that are not relevant.