Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include signature in deal query response #3388

Closed
anorth opened this issue Sep 11, 2019 · 2 comments
Closed

Include signature in deal query response #3388

anorth opened this issue Sep 11, 2019 · 2 comments
Assignees
@ingar

Comments

@anorth
Copy link
Member

anorth commented Sep 11, 2019

Description

The deal structures were reworked a bit when implementing signing (#3222), with the signature extracted to a wrapper. The CLI only returns the inner structure so the signature has been lost from output.

Acceptance criteria

  • The deal CLI returns a SignedResponse instead of a Response.

Risks + pitfalls

Where to begin
@ingar ingar self-assigned this Sep 11, 2019
@hazmatzo
Copy link

Let me know if you need payload information since I've spun it up on my machine recently.

@anorth
Copy link
Member Author

anorth commented Sep 12, 2019

Closed by #3389

@anorth anorth closed this as completed Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ingar ingar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ingar @anorth @hazmatzo