Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix units for value in message send #2263

Merged
merged 1 commit into from Mar 13, 2019
Merged

Fix units for value in message send #2263

merged 1 commit into from Mar 13, 2019

Conversation

lkowalick
Copy link
Contributor

Resolves #1819

travisperson
travisperson approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@travisperson travisperson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We'll have to follow up to support values other than integers later.

@lkowalick lkowalick requested review from rosalinekarr and removed request for shannonwells March 13, 2019 19:26
@lkowalick
Copy link
Contributor Author

@travisperson I have just filed #2265

@lkowalick lkowalick merged commit 2b7dc46 into master Mar 13, 2019
@lkowalick lkowalick deleted the bug/fix-message-send-value-units branch March 13, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisperson travisperson travisperson approved these changes

@rosalinekarr rosalinekarr rosalinekarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lkowalick @travisperson @rosalinekarr