add peer tracker to porcelain with Trust method #3408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
force-pushed
the
feat/peertracker-porcelain
branch
from
abba4ec
to
2e5c730
Compare
ZenGround0
reviewed
Sep 11, 2019
| @@ -69,6 +69,14 @@ func (tracker *PeerTracker) UpdateTrusted(ctx context.Context) error { | |||
| return tracker.updatePeers(ctx, tracker.trustedPeers()...) | |||
| } | |||
|
|
|||
| // Trust adds `pid` to the peer trackers trusted node set. | |||
| func (tracker *PeerTracker) Trust(pid peer.ID) { | |||
There was a problem hiding this comment.
Would it make sense to include an Untrust as well? If I were playing around with this on the CLI I wouldn't want to make a change I couldn't undo.
ZenGround0
approved these changes
Sep 11, 2019
|
Realizing this might now be ideal as the peers passed to peer tracker as "trusted" are not persisted to disk. Going to revisit at a later point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds the PeerTracker to porcelain. We need this for catch up syncing daemon tests as we must instruct daemons to trust each other in order for them to sync their chains initially. Without this daemons will be unable to move out of the catch up sync phase.