Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing data via SectorInfo, V7SectorInfo, SectorDeals, and MinerLockedFunds Extractors. #997

Closed
4 of 6 tasks
frrist opened this issue Jun 20, 2022 · 1 comment
Closed
4 of 6 tasks
Assignees
Labels
backfill required Alters data extraction such that backfilling is necessary data dump Related to the data dumps produced by lily kind/bug Kind: Bug P0 P0: Critical Blocker
Milestone

Comments

@frrist
Copy link
Member

frrist commented Jun 20, 2022

Describe the bug:

The following extractors contain a bug that causes them to miss data while extracting their respective models:

These bugs causes the models miner_sector_infos, miner_sector_infos_v7, and miner_sector_deals to undercount data and miner_locked_funds to miss all data, thus queries over these tables will not accurately represent the state of the chain. The models miner_sector_infos and miner_sector_infos_v7 record the state of newly added sectors:

  • Height and StateRoot a sector was added
  • Miner adding the sector and ID of the sector
  • Sectors SealedCID, ActivationEpoch, ExpirationEpoch, DealWeight, InitialPledge, ExpectedDayReward, ExpectedStoragePledge, and if the sector contains verified data

The model miner_sector_deals records which deals belong to which sectors:

  • Height deal was added to a sector
  • Miner adding sector and its ID
  • DealID’s contained in the sector.

The model miner_locked_funds records details of miner funds locked for adding sectors:

  • Height funds were changed
  • MinerID, initial pledge, pre-commit deposit, and locked funds.

It is worth pointing out that the model miner_sector_events is not affected by this and aggregations over its data will still return accurate counts of the different miner sector events (sectors added, snapped, faulted, recovered, etc.)

Lily Version: v0.9.0 - v0.10.0

This bug affects lily v0.9.0 and v0.10.0

TODO:

@frrist frrist added kind/bug Kind: Bug P0 P0: Critical Blocker backfill required Alters data extraction such that backfilling is necessary data dump Related to the data dumps produced by lily labels Jun 20, 2022
@frrist
Copy link
Member Author

frrist commented Jun 20, 2022

Release candidate created here: https://github.com/filecoin-project/lily/tree/v0.10.1-rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backfill required Alters data extraction such that backfilling is necessary data dump Related to the data dumps produced by lily kind/bug Kind: Bug P0 P0: Critical Blocker
Projects
None yet
Development

No branches or pull requests

3 participants