Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation plan for allowing SPs to move partitions proposal' in Lotus-Miner #11129

Closed
4 of 5 tasks
rjan90 opened this issue Aug 2, 2023 · 3 comments
Closed
4 of 5 tasks
Milestone

Comments

@rjan90
Copy link
Contributor

rjan90 commented Aug 2, 2023

Description
Work plan for the Lotus-Miner implementation of Allowing SPs to move partitions between deadlines. The proposal aims to add a method MovePartitions to move all sectors in one or more partitions from one deadline to another to give SPs control over the WindowPoSt time slots for sectors.

Techincal tasks

Testing tasks

  1. C-need-testing P1
@rjan90 rjan90 self-assigned this Aug 9, 2023
@rjan90
Copy link
Contributor Author

rjan90 commented Aug 9, 2023

Write CLI command lotus-miner proving deadline move --from [deadline | partition] --to [deadline]

Some addtional product considerations to this CLI:

  • Simulate the command if --really-do-it is not passed. Explain that --really-do-it needs to be passed to actually send the message
  • Ability to specify multiple partitions in a deadline that you want to move to a new deadline
    • Break messages into multiple messages if gas cost is high (when moving many partitions).

@rjan90
Copy link
Contributor Author

rjan90 commented Aug 9, 2023

Time estimation:

Techincal tasks:

  • Write CLI command lotus-miner proving deadline move --from [deadline | partition] --to [deadline] or potentially lotus-miner proving deadlines move --from [deadline | partition] --to [deadline]
    • 1 day
  • Create skeleton for testing in local devnet
    • 0.5 day

Testing tasks:

  • Local developer network testing plan:
    • 0.5 day
  • Butterfly network testing plan:
    • 1 day (but spread over a week, due to deadline partition table is similar to mainnet (24 hour cycle)

Total time estimation: 3 days

@rjan90 rjan90 changed the title Review/plan allowing SPs to move partitions impact on Lotus-Miner Implementation plan for allowing SPs to move partitions proposal' in Lotus-Miner Aug 10, 2023
@rjan90 rjan90 removed their assignment Sep 18, 2023
@rjan90 rjan90 added this to the Network v21 milestone Sep 18, 2023
@rjan90
Copy link
Contributor Author

rjan90 commented Oct 27, 2023

Closing this issue, as this has been implemented by: #11301

@rjan90 rjan90 closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant