Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI from CircleCI to GitHub Actions #11734

Closed
22 of 24 tasks
galargh opened this issue Mar 18, 2024 · 4 comments
Closed
22 of 24 tasks

Migrate CI from CircleCI to GitHub Actions #11734

galargh opened this issue Mar 18, 2024 · 4 comments
Assignees

Comments

@galargh
Copy link
Contributor

galargh commented Mar 18, 2024

User Story

GitHub Actions provides Developer Experience better suited for Lotus development team going forward.

Acceptance Criteria

  • The p50 and p95 success rate of the new GitHub Actions workflows is the same or higher than their CircleCI counterparts
  • The p50 and p95 execution time of the new GitHub Actions workflows is the same or smaller than their CircleCI counterparts (*p90 is worse for the Test workflow but it is due to an outlier caused by an issue with self-hosted runners that is being addressed)

Deliverables (GitHub Actions workflows)

Technical Breakdown

Tasks

Testing

@Stebalien
Copy link
Member

Any idea what caused the apt locking issue in https://github.com/filecoin-project/lotus/actions/runs/8529890853/job/23366624530?pr=11808?

@galargh
Copy link
Contributor Author

galargh commented Apr 3, 2024

Any idea what caused the apt locking issue in https://github.com/filecoin-project/lotus/actions/runs/8529890853/job/23366624530?pr=11808?

I have seen that before caused by ubuntu auto-updates but we disabled them since then. I propose we add extra logging to see what process is holding up the lock in case it happens in lotus again - #11815 Maybe bet would be that there is another scheduled process that is causing this.

@Stebalien
Copy link
Member

Any idea why test runs like a40cced are showing up as failed? I assume they're just getting cancelled because we're merging something else to master, unless something else is cancelling them.

@galargh
Copy link
Contributor Author

galargh commented Apr 5, 2024

Any idea why test runs like a40cced are showing up as failed? I assume they're just getting cancelled because we're merging something else to master, unless something else is cancelling them.

That's exactly it. We can disable this with - #11842. Cancelling in progress runs is quite useful in the PRs, but we can do without it in other cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants