Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lotus checks validity of messages at the sync stage #1464

Closed
arajasek opened this issue Mar 27, 2020 · 2 comments
Closed

Lotus checks validity of messages at the sync stage #1464

arajasek opened this issue Mar 27, 2020 · 2 comments

Comments

@arajasek
Copy link
Contributor

Afaic tell, nodes should only validate message signatures when syncing, and deal with invalid messahes when executing the message in the subsequent tipset. I think we do perform some message validity checks when syncing a block. Blocks with such invalid messages will not be added at all, which I believe is spec-incompliant. If true, this will obviously call interop issues.

Here is a non-exhaustive list of validity checks we seem to perform:

  • Sender can be found (happens when validating nonces)
  • Sender is an account (will only happen if sender address is an ID address)
  • Expected nonces (side-note: how do we order multiple messages from the same sender?)
@whyrusleeping
Copy link
Member

I think any discrepancies here have been resolved, right @arajasek ?

@arajasek
Copy link
Contributor Author

Yup...Idk what the spec says we should do, but we do reasonable things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants