Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable direct building of levelcache stores #72

Merged
merged 3 commits into from Mar 4, 2020

Conversation

cryptonemo
Copy link
Collaborator

No description provided.

@cryptonemo
Copy link
Collaborator Author

@dignifiedquire If this is urgent, it works and can be merged. Otherwise, I plan to add more tests and cleanups, etc. Let me know if this PR should also include the removal of the v1/v2 compaction, etc as well like we discussed. As-is, everything is backward compatible in terms of levelcache usage.

@cryptonemo cryptonemo force-pushed the levelcache-direct branch 2 times, most recently from c96e9c0 to f6cde56 Compare February 24, 2020 20:45
@dignifiedquire
Copy link

@cryptonemo if we want to make breaking changes in that front, we should get them in soon, likely sometime this week. No rush on getting this merged

@cryptonemo
Copy link
Collaborator Author

@dignifiedquire Not sure if this is what you're saying or opposing, but at this point, I think it's better to merge this separately, since it could be integrated/tested in rust-fil-proofs over time without impacting much else. At some later point when that later work is merged and compaction is no longer used, it makes sense to rip that all out then.

Copy link

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@cryptonemo
Copy link
Collaborator Author

cryptonemo commented Mar 4, 2020

Thanks, I'll merge this shortly. In the meantime, I've started testing out the integration and want to make sure all is well first. It's coming together, but not quite there yet. At the moment, I don't anticipate changes required here. Just being cautious ;-)

@cryptonemo
Copy link
Collaborator Author

@dignifiedquire Made a very minor cosmetic update. Will merge when CI is complete/happy.

@cryptonemo cryptonemo merged commit a8832a2 into master Mar 4, 2020
@cryptonemo cryptonemo deleted the levelcache-direct branch May 11, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants