Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace logging #188

Merged
merged 10 commits into from
Aug 25, 2022
Merged

Trace logging #188

merged 10 commits into from
Aug 25, 2022

Conversation

xosmig
Copy link
Contributor

@xosmig xosmig commented Aug 15, 2022

No description provided.

Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I like most of the improvements, except exposing the level (see comments).

pkg/logging/logger.go Outdated Show resolved Hide resolved
workers.go Outdated Show resolved Hide resolved
There is no really strong reason, I just find a struct more
appropriate and readable here than a wrapper type.
It is a bit more Go-idiomatic without a pointer.
@xosmig xosmig merged commit ef6127e into consensus-shipyard:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants