Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default handler registration to DSL module #199

Merged

Conversation

matejpavlovic
Copy link
Contributor

This is useful for modules that perform processing only on some events.
E.g., the default action could be forwarding to another module.

This is useful for modules that perform processing only on some events.
E.g., the default action could be forwarding to another module.

Signed-off-by: Matej Pavlovic <matopavlovic@gmail.com>
Copy link
Contributor

@xosmig xosmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a useful feature, thank you!

@xosmig
Copy link
Contributor

xosmig commented Aug 25, 2022

This may go well with this change I was thinking about but didn't add to the main branch yet: xosmig#2

@matejpavlovic matejpavlovic merged commit a73104a into consensus-shipyard:main Aug 25, 2022
@xosmig
Copy link
Contributor

xosmig commented Aug 25, 2022

Right now, the semantics of "not matching an event" is somewhat ambiguous because, in practice, we have a hierarchy of event types in Mir, but the core of DSL is only aware of the top level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants