Module generalization #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Pavlovic <matopavlovic@gmail.com>
sergefdrv
suggested changes
May 30, 2022
Instead, note that the Node might simply stop reading the ActiveModule's output. Signed-off-by: Matej Pavlovic <matopavlovic@gmail.com>
matejpavlovic
force-pushed
the
adr-0003-generalize-modules
branch
from
6643e36
to
6580000
Compare
sergefdrv
reviewed
May 31, 2022
sergefdrv
reviewed
May 31, 2022
sergefdrv
reviewed
May 31, 2022
Signed-off-by: Matej Pavlovic <matopavlovic@gmail.com>
matejpavlovic
force-pushed
the
adr-0003-generalize-modules
branch
from
6580000
to
e900c99
Compare
sergefdrv
approved these changes
May 31, 2022
dnkolegov
reviewed
May 31, 2022
Signed-off-by: Matej Pavlovic <matopavlovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matej Pavlovic matopavlovic@gmail.com