Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEVM | Eth Compliance Test | Implementation of delete_actor() is missing for test_vm runtime #1426

Closed
shamb0 opened this issue Jan 11, 2023 · 2 comments
Closed

FEVM | Eth Compliance Test | Implementation of delete_actor() is missing for test_vm runtime #1426

shamb0 opened this issue Jan 11, 2023 · 2 comments
Labels
Ethereum Compliance

Comments

@shamb0
Copy link

shamb0 commented Jan 11, 2023 •
edited

Implementation of delete_actor() is missing for test_vm runtime

Current Status

    fn delete_actor(&mut self, _beneficiary: &Address) -> Result<(), ActorError> {
        panic!("TODO implement me")
    }

Test vectors related to SELFDESTRUCT are skipped for now.

Test Suites skipped due to this error

Skip ID Test Suites
ID-0005 stArgsZeroOneBalance/suicideNonConst.json
ID-0006 stAttackTest/ContractCreationSpam.json
ID-0007 stBadOpcode/invalidAddr.json
ID-0009 stBugs/randomStatetestDEFAULT-Tue_07_58_41-15153-575192.json
ID-0010 stBugs/randomStatetestDEFAULT-Tue_07_58_41-15153-575192_london.json
ID-0011 stCallCodes/callcall_00_SuicideEnd.json
ID-0012 stCallCodes/callcallcall_000_SuicideEnd.json
ID-0013 stCallCodes/callcallcall_000_SuicideMiddle.json
ID-0015 stCallCodes/callcallcallcode_001_SuicideEnd.json
ID-0016 stCallCodes/callcallcallcode_001_SuicideMiddle.json
ID-0017 stCallCodes/callcallcode_01_SuicideEnd.json
ID-0018 stCallCodes/callcallcode_01_SuicideEnd.json
ID-0022 stCallCreateCallCodeTest/createFailBalanceTooLow.json
ID-0023 stCallCreateCallCodeTest/createInitFailBadJumpDestination.json
ID-0024 stCallCreateCallCodeTest/createInitFailBadJumpDestination2.json
ID-0025 stCallCreateCallCodeTest/createInitFailStackSizeLargerThan1024.json
ID-0026 stCallCreateCallCodeTest/createInitFailStackUnderflow.json
ID-0027 stCallCreateCallCodeTest/createInitFailUndefinedInstruction.json
ID-0028 stCallCreateCallCodeTest/createInitFailUndefinedInstruction2.json
ID-0029 stCallCreateCallCodeTest/createInitFail_OOGduringInit.json
ID-0030 stCallCreateCallCodeTest/createInitOOGforCREATE.json
ID-0031 stCallDelegateCodesCallCodeHomestead/callcodecall_10_SuicideEnd.json
ID-0032 stCallDelegateCodesCallCodeHomestead/callcodecallcode_11_SuicideEnd.json
ID-0033 stCallDelegateCodesCallCodeHomestead/callcodecallcodecall_110_SuicideEnd.json
ID-0034 stCallDelegateCodesCallCodeHomestead/callcodecallcodecall_110_SuicideMiddle.json
ID-0035 stCallDelegateCodesCallCodeHomestead/callcodecallcodecallcode_111_SuicideMiddle.json
ID-0036 stCallDelegateCodesCallCodeHomestead/callcodecallcodecallcode_111_SuicideMiddle.json
ID-0039 stCallDelegateCodesHomestead/callcallcodecall_010_SuicideEnd.json
ID-0040 stCallDelegateCodesHomestead/callcallcodecall_010_SuicideMiddle.json
ID-0042 stCallDelegateCodesHomestead/callcallcodecallcode_011_SuicideEnd.json
ID-0043 stCallDelegateCodesHomestead/callcallcodecallcode_011_SuicideMiddle.json
ID-0046 stCallDelegateCodesHomestead/callcodecallcall_100_SuicideMiddle.json
ID-0047 stCallDelegateCodesHomestead/callcodecallcall_100_SuicideEnd.json
ID-0050 stCallDelegateCodesHomestead/callcodecallcallcode_101_SuicideMiddle.json
ID-0053 stCallDelegateCodesHomestead/callcodecallcodecallcode_111_SuicideEnd.json
ID-0057 stCreateTest/CREATE_AcreateB_BSuicide_BStore.json
ID-0062 stCreateTest/CreateOOGafterMaxCodesize.json
ID-0063 stCreateTest/CreateResults.json
ID-0069 stEIP150singleCodeGasPrices/eip2929-ff.json
ID-0070 stEIP150singleCodeGasPrices/gasCost.json
ID-0071 stEIP150singleCodeGasPrices/gasCostBerlin.json
ID-0072 stEIP150Specific/SuicideToExistingContract.json
ID-0073 stEIP150Specific/SuicideToNotExistingContract.json
ID-0074 stEIP158Specific/CALL_ZeroVCallSuicide.json
ID-0075 stEIP1559/baseFeeDiffPlaces.json
ID-0076 stEIP1559/gasPriceDiffPlaces.json
ID-0077 stEIP2930/variedContext.json
ID-0078 stExtCodeHash/extCodeHashDeletedAccount.json
ID-0079 stExtCodeHash/extCodeHashDeletedAccount1.json
ID-0080 stExtCodeHash/extCodeHashDeletedAccount2.json
ID-0082 stExtCodeHash/extcodehashEmpty.json
ID-0083 stInitCodeTest/CallRecursiveContract.json
ID-0084 stNonZeroCallsTest/NonZeroValue_SUICIDE.json
ID-0085 stNonZeroCallsTest/NonZeroValue_SUICIDE_ToEmpty.json
ID-0086 stNonZeroCallsTest/NonZeroValue_SUICIDE_ToNonNonZeroBalance.json
ID-0087 stNonZeroCallsTest/NonZeroValue_SUICIDE_ToOneStorageKey.json
ID-0088 stNonZeroCallsTest/NonZeroValue_TransactionCALL.json
ID-0089 stNonZeroCallsTest/NonZeroValue_TransactionCALLwithData.json
@shamb0 shamb0 mentioned this issue Jan 11, 2023
Closed
@shamb0
Copy link
Author

shamb0 commented Jan 11, 2023

CC @maciejwitowski @mriise

@shamb0 shamb0 changed the title Implementation of delete_actor() is missing for test_vm runtime FEVM | Eth Compliance Test | Implementation of delete_actor() is missing for test_vm runtime Jan 11, 2023
@maciejwitowski maciejwitowski transferred this issue from filecoin-project/builtin-actors Jan 11, 2023
@maciejwitowski maciejwitowski added Kind: Bug Something isn't working Ethereum Compliance and removed Kind: Bug Something isn't working labels Jan 11, 2023
@shamb0
Copy link
Author

shamb0 commented Jan 12, 2023

Replacing it with ref-fvm issue ID 1435 | #1435

@shamb0 shamb0 closed this as completed Jan 12, 2023
@shamb0 shamb0 mentioned this issue Jan 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Ethereum Compliance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maciejwitowski @shamb0