Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Piece Inclusion Proof #421

Closed
porcuquine opened this issue Jan 2, 2019 · 6 comments
Closed

Integrate Piece Inclusion Proof #421

porcuquine opened this issue Jan 2, 2019 · 6 comments
Assignees

Comments

@porcuquine
Copy link
Collaborator

Piece Inclusion Proof is integrated into Filecoin

@porcuquine porcuquine self-assigned this Jan 2, 2019
@mhammersley mhammersley added launch-critical P0 Highest priority labels Jan 25, 2019
@mhammersley
Copy link

matching labels to info in Filecoin Research Prioritization List

@mhammersley
Copy link

mhammersley commented Feb 4, 2019

@porcuquine: @whyrusleeping and @nicola think this is done and specced. is this issue ready to close?

@porcuquine
Copy link
Collaborator Author

porcuquine commented Feb 4, 2019

No: It's specced, but the implementation is not connected to the API. There is no way to actually get a piece inclusion proof yet, and there will need to be changes to how pieces are packed within sectors as part of the implementation. Those changes will probably want to filter back into the spec in some form as well.

@porcuquine
Copy link
Collaborator Author

Also, this is not P0.

@mhammersley
Copy link

@porcuquine, apologies for delay; i just saw your note in the spreadsheet online. i'll defer to your judgment on whether this should be p1 or p2, then. do you still agree it's launch-critical?

@porcuquine
Copy link
Collaborator Author

Probably P2 right now. My understanding is that it's need for launch, meaning mainnet — but it's explicitly not prioritized yet.

@mhammersley mhammersley added P2 Low priority and removed P0 Highest priority labels Mar 1, 2019
@porcuquine porcuquine added the cryptocomputelab CryptoComputeLab work label Mar 8, 2019
@porcuquine porcuquine assigned sidke and unassigned porcuquine Apr 10, 2019
@sidke sidke added the Epic label Apr 10, 2019
@laser laser closed this as completed Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants