Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI build should fail if parameters.json manifest is out of date or if files referenced in manifest aren't fetchable from IPFS #541

Closed
porcuquine opened this issue Mar 12, 2019 · 1 comment
Labels
P2 Low priority

Comments

@porcuquine
Copy link
Collaborator

porcuquine commented Mar 12, 2019

Description

Create a way to verify that all required groth parameters have been published, and add it as a CI check.

In order to ensure the checked parameters correspond exactly to those which would be generated by paramcache, it probably makes sense to extend that utility with a --check option.

This would:

  • Determine the names of the parameters which would be generated by paramcache.
  • Check to ensure that these are the parameters specified in parameters.json.
  • If so, verify that each parameter's Cid is fetchable via IPFS.
  • If any of these checks fail, exit with non-zero exit code.

NOTE: this assumes that if a Cid for a parameters file exists in IPFS, then it does indeed correspond to the generated parameters. If we cannot make this assumption, we have to run paramcache again to generate the real parameters, which is impractical as a check.

Once implemented, add a CI job which runs the check and fails the job if all required parameters have not been published.

Acceptance criteria

CI fails when parameters.json is not up-to-date or contains references to Cids which cannot be fetch from IPFS.

Risks + pitfalls

Where to begin

@porcuquine porcuquine added the P2 Low priority label Mar 12, 2019
@laser laser self-assigned this Jul 19, 2019
@laser laser changed the title add groth param check for CI CircleCI build should fail if parameters.json manifest is out of date or if files referenced in manifest aren't fetchable from IPFS Jul 23, 2019
@laser laser removed their assignment Sep 17, 2019
@vmx
Copy link
Contributor

vmx commented Sep 12, 2023

This was most useful pre mainnet. But now the parameters won't change that often. Hence I dare to close that issue as "won't fix".

@vmx vmx closed this as completed Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Low priority
Projects
None yet
Development

No branches or pull requests

3 participants