Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase expansion parents from 8 to 16 #857

Closed
schomatis opened this issue Sep 1, 2019 · 4 comments
Closed

Increase expansion parents from 8 to 16 #857

schomatis opened this issue Sep 1, 2019 · 4 comments
Assignees

Comments

@schomatis
Copy link
Contributor

To conform with new analysis (see #827). Although straightforward we should check any potential impacts (e.g., parents cache size, replication time, change in the circuits).

@schomatis
Copy link
Contributor Author

Ideally this should come after the changes in #791 I think (not blocking, though).

@porcuquine
Copy link
Collaborator

In keeping with notes on #827, I don't think we should change the value of the parameter. I think we should instead be generating more parents given the same parameter.

@dignifiedquire
Copy link
Contributor

I think we should instead be generating more parents given the same parameter.

In this case we would need a second parameter, or something else, that gives us the upper bound of parents, as that is critical to have, especially in light of #791

@schomatis
Copy link
Contributor Author

Will be fixed in #864.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment