Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mobile nav #1001

Merged
merged 2 commits into from
Jul 22, 2020
Merged

fix: mobile nav #1001

merged 2 commits into from
Jul 22, 2020

Conversation

olizilla
Copy link
Collaborator

@olizilla olizilla commented Jul 21, 2020

  • Fix broken nav layout on small screens
  • Update baseof template with latest changes from book theme
  • Hide the in page contents menu on mobile. 2 hambergers is too many. - ok ok ok
  • Add the ⨎ilecoin logo
  • fix the in page toc nav
Menu closed Menu open
Screen Shot 2020-07-22 at 11 28 23 Screen Shot 2020-07-22 at 11 28 27

Fixes #997

License: MIT
Signed-off-by: Oli Evans oli@tableflip.io

- Fix broken nav layout on small screens
- Update baseof template with latest changes from book theme
- Hide the in page contents menu on mobile. 2 hambergers is too many.

Fixes #997

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@hugomrdias
Copy link
Contributor

dunno if i agree with the right nav removal, some pages are pretty big.
check https://docs.gitbook.com/ for inspiration.

can we do just the other 2 fixes in this PR and talk about mobile right nav in another issue/pr ?

@olizilla
Copy link
Collaborator Author

olizilla commented Jul 21, 2020

2 hamburgers 2 furious

the first pass at this PR just disabled the mobile nav toc, screenshots below for posterity

Menu closed Menu open
Screen Shot 2020-07-21 at 14 30 50 Screen Shot 2020-07-21 at 14 30 53

@olizilla
Copy link
Collaborator Author

the gitbook one looks nice, but 2 hambergers remains 1 too many hamburgers. Everyone be scrolling.

@hugomrdias
Copy link
Contributor

I don't like it either, but feels necessary for big pages and it seems to be a common thing in other docs frameworks.

ok ok @hugomrdias, here is a quick ting.

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@olizilla olizilla changed the title fix: hide checkbox inputs on mobile nav fix: mobile nav Jul 22, 2020
@olizilla
Copy link
Collaborator Author

plz eye dis @hugomrdias

@olizilla
Copy link
Collaborator Author

as a next ting, we can add a script to hide the toc if it is empty. It is possible to hide it via frontmatter, but that changes the layout, as the right column isnt rendered... on 99% of pages we just want to hide the toc if there are no headers, but there is no easy way to do that in hugo. 1 line of js can solve it tho.

@hugomrdias
Copy link
Contributor

love it 😍 😻

@hugomrdias hugomrdias merged commit 55ebbe1 into beta Jul 22, 2020
@hugomrdias hugomrdias deleted the fix-mobile-nav branch July 22, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beta mobile layout issues
2 participants