Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: table dashboard #1003

Merged
merged 6 commits into from
Jul 23, 2020
Merged

feat: table dashboard #1003

merged 6 commits into from
Jul 23, 2020

Conversation

hugomrdias
Copy link
Contributor

@hugomrdias hugomrdias commented Jul 21, 2020

This PR adds a Spec status dashboard

Screenshot 2020-07-21 at 19 04 19

todo:

  • documentation for the frontmatter properties

closes #985

@hugomrdias hugomrdias self-assigned this Jul 21, 2020
@hugomrdias hugomrdias marked this pull request as draft July 21, 2020 18:02
yiannisbot
yiannisbot previously approved these changes Jul 22, 2020
Copy link
Collaborator

@yiannisbot yiannisbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work @hugomrdias!

olizilla
olizilla previously approved these changes Jul 22, 2020
Copy link
Collaborator

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! My comments are all minor, this is ready to roll.

layouts/shortcodes/dashboard-table.html Outdated Show resolved Hide resolved
layouts/shortcodes/dashboard-table.html Outdated Show resolved Hide resolved
layouts/shortcodes/dashboard-table.html Outdated Show resolved Hide resolved
layouts/shortcodes/dashboard-table.html Outdated Show resolved Hide resolved
@olizilla
Copy link
Collaborator

I love space and breathing room very much... but I think for this table we might actually want information density to be the thing... like "I want to see as much of the table as possible at once". Normally that would be a ux no no, but as the cells only confer the state of a enum rather than arbitrary precision numbers, it's not so bad... something like 0 vertical padding and font size 12px...

Screenshot 2020-07-22 at 09 50 13

@daviddias
Copy link
Contributor

Recommendation for the headers

image

@daviddias
Copy link
Contributor

Does the weight need to be here?
image

@daviddias
Copy link
Contributor

Btw, with this, it should be easy to get the 3 metric as well at the top, correct (Progress, Risk & Consequence)? (perhaps at least just Progress?)

@hugomrdias
Copy link
Contributor Author

Does the weight need to be here?
image

Its useful to sort by weight

Btw, with this, it should be easy to get the 3 metric as well at the top, correct (Progress, Risk & Consequence)? (perhaps at least just Progress?)

Yes we will have the metrics here.

Regarding the headers, the table is already scoped to the Spec. Implementations will have another table below this one. Do you think we still need to use Theory Audit and Compliance Tests ?

@hugomrdias hugomrdias marked this pull request as ready for review July 22, 2020 16:31
@daviddias
Copy link
Contributor

Do you think we still need to use Theory Audit and Compliance Tests ?

Yes, using consisting terminology in a project where every key word is overloaded is essential for clarity and avoiding misinformation

Copy link
Collaborator

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lets land this!

@hugomrdias hugomrdias merged commit 71f3720 into beta Jul 23, 2020
@yiannisbot
Copy link
Collaborator

Fantastic work @hugomrdias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard for spec status
4 participants