Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure light mode even if dark mode OS pref #1029

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

olizilla
Copy link
Collaborator

@olizilla olizilla commented Jul 28, 2020

  • Ignore users OS pref. Light mode is the default regardless. (this fixes light-mode choice not preserved for uses with dark-mode set as OS default.)
  • Fix search results to respect color-scheme preference.

License: MIT
Signed-off-by: Oli Evans oli@tableflip.io

we optimise by setting the dark mode as early as we can, but that means we need an extra step to catch those dark mode OS folks who want their specs to stay white

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@olizilla olizilla added the hint: beta Hint: Issues related to the beta branch label Jul 28, 2020
ignore the OS pref, just default to light mode.

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@olizilla olizilla requested a review from hugomrdias July 28, 2020 15:00
@hugomrdias hugomrdias merged commit 605a49e into beta Jul 28, 2020
@hugomrdias hugomrdias deleted the fix-light-mode-site-on-dark-mode-os branch July 28, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hint: beta Hint: Issues related to the beta branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants