feat: figures with open in tab link #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the main branch you can open diagrams in a new tab. This commit explores bringing them back. License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
|
@hugomrdias i know you've thought about this... did you have a solution in mind? |
|
im not seeing the question, sorry can you explain further please |
|
@hugomrdias There used to be links next to diagrams that let the user open them in a new tab, which seems like a good thing... You mentioned this in passing in a conversation, so I wondered if you had a plan for bringing back the "open diagram in new tab" links. This PR is just a proposal. |
- Improve styling of embedded svgs. - Use semantic figure and figurecaption elements. - Add open in tab link - Pull svgs and source files into the intro section as appropriate License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
olizilla
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the main branch you can open diagrams in a new tab. This PR brings them back to beta in a nicer form:
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io