Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): FIL VM State Tree Update #1057

Merged
merged 6 commits into from
Aug 31, 2020
Merged

fix(content): FIL VM State Tree Update #1057

merged 6 commits into from
Aug 31, 2020

Conversation

yiannisbot
Copy link
Collaborator

This PR is an update to the VM state tree and the (most important) functions related to updating it.

@anorth please advise on important things not currently mentioned, as well as on whether the TODO at the end is still relevant or not.

@schomatis schomatis removed their request for review August 13, 2020 15:46
@schomatis
Copy link
Contributor

I'm not sure if we want to make the snapshot system part of the spec, other than that I have little to add here.

@yiannisbot
Copy link
Collaborator Author

I've included mention of the snapshot system to hint on the fact that a view of the current state is needed/is useful in multiple occasions. I believe this is useful for any implementation to have, but I'm not strong about it. I can either enhance the text to make the point clearer if we want to have it in, or exclude if not.

Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all just looks like Lotus implementation detail to me. The only piece that is relevant to other implementers is that the top layer of the state tree is a HAMT.

@yiannisbot
Copy link
Collaborator Author

@anorth I've excluded implementation details on snapshots as well as the code snippets and added a link to the lotus repo.

anorth
anorth previously approved these changes Aug 20, 2020
@yiannisbot
Copy link
Collaborator Author

yiannisbot commented Aug 30, 2020

Thanks @anorth! Fixed some links to external modules and set status to "reliable".

@hugomrdias let's merge this.

@hugomrdias hugomrdias added this to the Beta v1 milestone Aug 31, 2020
@hugomrdias hugomrdias added this to In progress in beta.spec.filecoin.io via automation Aug 31, 2020
@yiannisbot yiannisbot added the hint: ready to merge Hint: PR is ready to be merged label Aug 31, 2020
@hugomrdias hugomrdias changed the title FIL VM State Tree Update fix(content): FIL VM State Tree Update Aug 31, 2020
@hugomrdias hugomrdias merged commit caf25fc into beta Aug 31, 2020
beta.spec.filecoin.io automation moved this from In progress to Done Aug 31, 2020
@hugomrdias hugomrdias deleted the fil-vm-statetree branch August 31, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hint: ready to merge Hint: PR is ready to be merged
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants