Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zoom and pipelines #1093

Merged
merged 11 commits into from
Aug 26, 2020
Merged

feat: zoom and pipelines #1093

merged 11 commits into from
Aug 26, 2020

Conversation

hugomrdias
Copy link
Contributor

@hugomrdias hugomrdias commented Aug 25, 2020

fix: improve pipelines watcher

feat: lightbox for images

feat: add watch

feat: fix links, support diagrams in images and pipelines

Pipelines support mmd and dot Links now show .Page.Title in the link text
if available Remove figure, h, svg shortcodes, we can just use now

fix: switch to d3 zoomable

closes #1087

@hugomrdias hugomrdias changed the base branch from master to beta August 25, 2020 15:04
olizilla
olizilla previously approved these changes Aug 26, 2020
Copy link
Collaborator

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rad. I notice that I don't get live-reload on image changes... i tried editing a dot file and it correctly rebuilt but livereload did not kick in. Changes to html do trigger it. Do you see that too?

tools/diagrams.js Show resolved Hide resolved
tools/diagrams.js Show resolved Hide resolved
README.md Show resolved Hide resolved
@olizilla olizilla added this to In progress in beta.spec.filecoin.io via automation Aug 26, 2020
@olizilla olizilla added the hint: beta Hint: Issues related to the beta branch label Aug 26, 2020
@hugomrdias
Copy link
Contributor Author

This is rad. I notice that I don't get live-reload on image changes... i tried editing a dot file and it correctly rebuilt but livereload did not kick in. Changes to html do trigger it. Do you see that too?

you probably still have the SW registered, remove it and it will not register again in dev

@olizilla
Copy link
Collaborator

Something is wonky with the image loading on the prod site

Screenshot 2020-08-26 at 14 53 04

package.json Outdated Show resolved Hide resolved
@olizilla
Copy link
Collaborator

@hugomrdias you like this? #1104

@hugomrdias hugomrdias merged commit df1c7d1 into beta Aug 26, 2020
beta.spec.filecoin.io automation moved this from In progress to Done Aug 26, 2020
@hugomrdias hugomrdias deleted the feat/pipelines branch August 26, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hint: beta Hint: Issues related to the beta branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

zoom is not centered
2 participants