chore: refactor to a single watcher #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add watch.js to configure chokidar. - pass watcher to each tool via an exported `configureWatcher` method. - allow tools to be run as scripts or required as modules License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
|
This is based off of the tic-toc branch for #1122 as re-working the watcher is a significant change that is unrelated to the goal of that PR. |
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
hugomrdias
approved these changes
Sep 2, 2020
olizilla
added a commit
that referenced
this pull request
Sep 2, 2020
- Avoid building the ToC and the dashboard on the client side by parse data from dom and building the toc from data. Generates a toc.json file in the hugo data dir, which is then used by the toc partial and the dashboard-spec shortcode. fixes #1125 - Refactor watchers. Add watch.js to configure chokidar. Pass watcher to each tool via an exported `configureWatcher` method. Allow tools to be run as scripts or required as modules see #1133 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configureWatchermethod.If run directly, the tool assumes it should process all things it cares about. If required as module, it does nothing, and allows the calling code to use it to configure the watcher.
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io