review feedback for actors.md #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dignifiedquire @porcuquine could I get some eyes on the submitPoSt method? I want to make sure we caught all the issues here. |
| func CommitSector(commD, commR []byte, proof *SealProof) SectorID { | ||
| if !miner.ValidatePoRep(commD, commR, miner.PublicKey, proof) { | ||
| // NotYetSpeced: ValidatePoRep, EnsureSectorIsUnique, CollateralForSector | ||
| func CommitSector(comm Commitment, proof *SealProof) SectorID { |
There was a problem hiding this comment.
should define Commitment or add it to not yet speced
actors.md
Outdated
| ## Storage Market Actor | ||
|
|
||
| The storage market actor is the central point for the Filecoin storage market. It is responsible for registering new miners to the system, and maintaining the power table. |
There was a problem hiding this comment.
Maybe add something about the fact that THE storage market lives at a specific address, and is the only one that will be accepted in operations?
dignifiedquire
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.