Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet screening #1074

Closed
2 of 3 tasks
juliangruber opened this issue Nov 3, 2023 · 4 comments · Fixed by #1075
Closed
2 of 3 tasks

Wallet screening #1074

juliangruber opened this issue Nov 3, 2023 · 4 comments · Fixed by #1075
Assignees

Comments

@juliangruber
Copy link
Member

juliangruber commented Nov 3, 2023

Screen destination wallet addresses, for legal reasons

@bajtos
Copy link
Member

bajtos commented Nov 6, 2023

Is it enough to validate the address here in the client? It's relatively easy to bypass this check by either modifying the Station source code or invoking the smart contract directly.

Shouldn't the smart contract reject sanctioned addresses too? (I know this is a much more complex thing to implement.)

@bajtos
Copy link
Member

bajtos commented Nov 6, 2023

How about Station Core? Should it screen the user-provided wallet address, too?

@juliangruber
Copy link
Member Author

Is it enough to validate the address here in the client? It's relatively easy to bypass this check by either modifying the Station source code or invoking the smart contract directly.

Shouldn't the smart contract reject sanctioned addresses too? (I know this is a much more complex thing to implement.)

We have discussed this in the #station-legal channel (or maybe it was just in the call), client side validation is good enough for now. I also brought up that the only proper way to do this is in the smart contract, unfortunately however Chainalysis' oracle is not published to the Filecoin block chain. Therefore, it would be a significant amount of work (and potentially cost) to mirror it over.

@juliangruber
Copy link
Member Author

How about Station Core? Should it screen the user-provided wallet address, too?

Good idea, let's do that too

filecoin-station/core#249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

2 participants