Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic SP fees pricing #269

Closed
filefilegoadmin opened this issue Jul 20, 2023 · 6 comments
Closed

Dynamic SP fees pricing #269

filefilegoadmin opened this issue Jul 20, 2023 · 6 comments
Assignees

Comments

@filefilegoadmin
Copy link
Contributor

A storage provider should be able to explicitly set the fee/free for specific file

@filefilegoadmin filefilegoadmin self-assigned this Jul 20, 2023
@filefilegoadmin
Copy link
Contributor Author

UI work must also be done

@filefilegoadmin
Copy link
Contributor Author

Notes: This feature should override the node's global fees per byte. There is some refactoring needed in order for us to support this feature. The refactoring includes the following:

  1. DB file metadata to indicate if fees are set
  2. Data query response contains the SP's global storage_per_byte and we rely on that. Now with this feature for each file in the data query response we need to specify the fee.

@filefilegoadmin
Copy link
Contributor Author

filefilegoadmin commented Aug 1, 2023

  1. Currently 0 Fees means its a free data retrieval, and anything else is the actual fees per byte. This feature should work in the following cases:
  • Even if global fees are 0, we can specify the amount needed for the specific file
  • If non zero, we can still specify a file with 0 fees

With the above implementation we can cover every possible combination of dynamic pricing

@filefilegoadmin filefilegoadmin changed the title When uploading file choose if it can be freely downloaded Dynamic SP fees pricing Aug 1, 2023
@filefilegoadmin
Copy link
Contributor Author

We might need an additional protocol to identify SP capabilities and settings. e.g. we could know if SP allows dynamic fees and such so we can propagate this capabilities to UI and other apps

@filefilegoadmin
Copy link
Contributor Author

In the storage access token introspection rpc method, we have the field which shows if we can override the fees

@filefilegoadmin
Copy link
Contributor Author

Work have been completed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant