-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate rebuilds of dist/ when we land code on master #404
Comments
Is there a desire to maintain (and version) |
Travis CI also appears to support automatically publishing to npmjs.org after a successful build (as well as a number of other providers). |
@0xazure to your first question, I think that the least surprising thing would be for the code in To your second point, I agree that having travis do this via a deploy step on Travis is the best option. |
Definitely agreed that this is the least surprising thing. I wanted to confirm that we want to keep I ask because I'm not as familiar with the practice of versioning build artifacts as part of the main project repository, I'm more used to seeing them published to a repository (such as npm) and/or available through a releases page (such as GitHub releases). |
I would say that we can probably move to a model where we only release via
@modeswitch what do you want to do? |
Let's leverage
Probably we can remove Also, we should figure out if there is a CDN we can/should update when we release something. |
This is fixed now. |
We keep a pre-built version of Filer's bundle in
dist/
. Currently, it will lag behind the code onmaster
unless manually updated. This is error prone, since people will forget, or not know to do this. We should consider letting Travis do it for us when we're merging ontomaster
.Similarly, once we have that, we should also tackle
npm
republishing of the module.The text was updated successfully, but these errors were encountered: