Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Crash when moving a bunch of files #13915

Open
KloWhrhyde opened this issue Nov 16, 2023 · 3 comments
Open

Bug: Crash when moving a bunch of files #13915

KloWhrhyde opened this issue Nov 16, 2023 · 3 comments
Labels
bug Something isn't working 👀 crash Bug reports involving a crash help wanted Extra attention is needed

Comments

@KloWhrhyde
Copy link

KloWhrhyde commented Nov 16, 2023

Description

When i do a lot of cutting / copying / paste of large files / high number of files, the CPU Usage is going up crazily, At least 50 to 100 %, when it reach 100 % the app usally is stuck or crash.

CPU : AMD RYZEN 3900X

image : Simulating the Issue in moving 12 MKV Files from a folder to another on the same disk.
FILESHIGHUSAGE

Steps To Reproduce

1 Try to move or copy 10+ large folders/files (500 mb+) on the same drive
2 the issue is worse if there is errors in the queue
3 App stuck then Crash or 100 % CPU Usage

Requirements

  • Fix crash that occurs when copying large amount of files
  • Fix high CPU Usage in this usecase

Files Version

3.0.5.0

Windows Version

10.0.22621.2428

Log File

debug.log

@KloWhrhyde KloWhrhyde added the bug Something isn't working 👀 label Nov 16, 2023
@yaira2
Copy link
Member

yaira2 commented Nov 16, 2023

Thanks for the report. We're tracking performance issues in #4180, but let's keep this open as well until the crash is fixed.

@yaira2 yaira2 changed the title Abnormaly High CPU Usage on Moving / Renaming Large folders Bug: Crash when moving a bunch of files Nov 16, 2023
@yaira2 yaira2 added help wanted Extra attention is needed crash Bug reports involving a crash labels Nov 16, 2023
@yaira2
Copy link
Member

yaira2 commented Nov 16, 2023

   at Microsoft.Win32.SafeHandles.SafeFileHandle.CreateFile(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize)```

@yaira2
Copy link
Member

yaira2 commented Nov 16, 2023

We're also actively working on performance improvements for file operations. Fyi @hez2010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👀 crash Bug reports involving a crash help wanted Extra attention is needed
Projects
Status: 🔖 Ready to build
Development

No branches or pull requests

2 participants