Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Second item in sub menu is selected first when using arrow key navigation #15138

Closed
andrew-james-heard opened this issue Apr 8, 2024 · 9 comments
Labels
bug Something isn't working 👀 needs - winui Requires changes from WinUI

Comments

@andrew-james-heard
Copy link

What feature or improvement do you think would benefit Files?

file > context button or right-click > Open with (has focus) > right-cursor > submenu is displayed but nothing has focus...
but to give keyboard focus to the 1st item in the list I now have to press cursor-down (2nd item is selected), cursor-up (1st item is selected)
in other words it takes 1 less key to select the 2nd item than the 1st
I haven't discovered any other way from the keyboard to more efficiently select the 1st item in the sub-menu

Requirements

  • give 1st item in the sub-menu focus when cursor-right is pressed?

Files Version

3.3.0.0

Windows Version

11 23H2

Comments

No response

@0x5bfa
Copy link
Member

0x5bfa commented Apr 8, 2024

Thanks for the feedback. I can repro.

Recording.2024-04-08.110554.mp4

@0x5bfa 0x5bfa added bug Something isn't working 👀 and removed feature request labels Apr 8, 2024
@andrew-james-heard
Copy link
Author

Thanks for the video - exactly. I wasn't going to presume it was a bug.

@Josh65-2201 Josh65-2201 changed the title no submenu item is selected after right-cursor from menu fly-out Bug: Second item in sub menu is selected first when using arrow key navigation Apr 8, 2024
@yaira2
Copy link
Member

yaira2 commented Apr 8, 2024

File Explorer has the same bug so I assume this needs to be fixed by WinUI.

@andrew-james-heard
Copy link
Author

confirmed same with Explorer ;-(
fixed by WinUI assuming both programs use the same menu handling code (but sounds like they do)

@0x5bfa 0x5bfa added the needs - winui Requires changes from WinUI label Apr 8, 2024
@yaira2
Copy link
Member

yaira2 commented Apr 8, 2024

Can you open a report on the WinUI repo?

@andrew-james-heard
Copy link
Author

WinUI? official Windows User Interface? I have no idea how sorry. Suggestion?

@yaira2
Copy link
Member

yaira2 commented Apr 8, 2024

My apologies, WinUI is the UI framework used in Files https://github.com/microsoft/microsoft-ui-xaml/issues.

@andrew-james-heard
Copy link
Author

I've created microsoft/microsoft-ui-xaml#9519

@yaira2
Copy link
Member

yaira2 commented Jun 4, 2024

Thank you Andrew, once this is resolved with WinUI, we should be able to take the fix for Files.

I think we can close this issue now as it's being tracked on the WinUI repo.

@yaira2 yaira2 closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👀 needs - winui Requires changes from WinUI
Projects
Status: Done
Development

No branches or pull requests

3 participants