Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Updated the design for Dual Pane mode #15469

Merged
merged 16 commits into from
May 27, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 25, 2024

TBA in the next release officially.

  • Remove accent color on the bottom for the active pane to display
  • Use shadow and focus background only for the active pane

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app
  2. Open the one more pane
  3. Open InfoPane
  4. Make window smaller and see InfoPane at the bottom

Screenshots
image

@0x5bfa
Copy link
Member Author

0x5bfa commented May 26, 2024

I moved background/borderbrush to each user control's Grid to remove unneeded xaml tree (like you did in #7824). Should I separate changes?

@yaira2
Copy link
Member

yaira2 commented May 26, 2024

I moved background/borderbrush to each user control's Grid to remove unneeded xaml tree (like you did in #7824). Should I separate changes?

I think it'll be easier for future reference if it's separate.

@yaira2
Copy link
Member

yaira2 commented May 26, 2024

Nice work on the shadows!

@yaira2
Copy link
Member

yaira2 commented May 26, 2024

We should make sure to test this with Column View

Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
@yaira2 yaira2 marked this pull request as ready for review May 26, 2024 16:25
@yaira2 yaira2 changed the title Feature: Dual pane design tweak Feature: Updated the design for Dual Pane mode May 26, 2024
@yaira2 yaira2 force-pushed the 5bfa/Feature-PaneHolderDesignTweak branch 2 times, most recently from 2a576b9 to 57bc6a6 Compare May 26, 2024 16:44
@yaira2 yaira2 force-pushed the 5bfa/Feature-PaneHolderDesignTweak branch from 57bc6a6 to 90e4926 Compare May 26, 2024 16:49
@XTorLukas

This comment was marked as off-topic.

@yaira2 yaira2 marked this pull request as draft May 26, 2024 20:55
@XTorLukas
Copy link
Contributor

How about instead of changing the shadow, which isn't as pronounced, you use the pane selector.

003524.mp4

@files-community files-community locked and limited conversation to collaborators May 26, 2024
@yaira2 yaira2 force-pushed the 5bfa/Feature-PaneHolderDesignTweak branch from 418b448 to da8a151 Compare May 26, 2024 23:12
@yaira2 yaira2 force-pushed the 5bfa/Feature-PaneHolderDesignTweak branch from 7e0da79 to 070d504 Compare May 26, 2024 23:22
@yaira2
Copy link
Member

yaira2 commented May 27, 2024

@XTorLukas thank you for your feedback, additional design work will take place in a second PR.

@files-community files-community unlocked this conversation May 27, 2024
@yaira2 yaira2 marked this pull request as ready for review May 27, 2024 03:09
yaira2
yaira2 previously approved these changes May 27, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 27, 2024
@yaira2 yaira2 merged commit 59066a8 into files-community:main May 27, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Feature-PaneHolderDesignTweak branch May 28, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants