-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Updated the design for Dual Pane mode #15469
Feature: Updated the design for Dual Pane mode #15469
Conversation
I moved background/borderbrush to each user control's Grid to remove unneeded xaml tree (like you did in #7824). Should I separate changes? |
I think it'll be easier for future reference if it's separate. |
Nice work on the shadows! |
We should make sure to test this with Column View |
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
2a576b9
to
57bc6a6
Compare
57bc6a6
to
90e4926
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
How about instead of changing the shadow, which isn't as pronounced, you use the pane selector. 003524.mp4 |
418b448
to
da8a151
Compare
7e0da79
to
070d504
Compare
@XTorLukas thank you for your feedback, additional design work will take place in a second PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TBA in the next release officially.
Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
Screenshots