Showing folder size in details view

[pbakes]

There are so many third-party file explorer's that offer showing folder size, e.g. Explorer++, Xinorbis, WizTree, TreeSize, still nothing that allows you to view folder size in Explorer. Files, as far as the UI is concerned, is much better than all those alternatives. It would be nice to see that functionality implemented.

[gave92]

This is something we have looked at in the past and decided against implementing due to the performance issues involved.
[Internal comment] Not sure if the new caching feature could change this, perhaps doing it in the background from the fulltrust process? Perhaps an alternative way is to provide a "calculate size" button to calculate it on-demand?

[d2dyno1]

Perhaps a setting for this would suffice?

[R3voA3]

It's important that the preview is not slowed down any further, it's already slow for folder with many child folders.

[yaira2]

@gave92 Do you think that if we added a calculate button, that it should calculate all items, or would it be an individual option for each folder?

[gave92]

@yaichenbaum I was thinking about a button that calculates size for all currently selected folders.

[cinqmilleans]

@gave92 @yaichenbaum @d2dyno1
I did a trial implementation. This does not reduce performance so much because the sizes are calculated after displaying the rest. I do think, however, that this should be a setting, (disabled by default). The implementation only calculates once per element and displays in the size column and footer.

FolderSize.mp4

[yaira2]

@cinqmilleans that doesn't look too bad, does it have any impact on performance at all?

[cinqmilleans]

@yaichenbaum I did not see any noticeable loss. The sizes update last without blocking the user interface. We can therefore do everything even if the sizes have not finished loading: open a sub-folder, rename, ....

[yaira2]

@yaichenbaum I did not see any noticeable loss. The sizes update last without blocking the user interface. We can therefore do everything even if the sizes have not finished loading: open a sub-folder, rename, ....

@cinqmilleans do you want to add this as an experimental option?

[cinqmilleans]

@yaichenbaum Yes of course. I prepare this.

[yaira2]

@pbakes this issue should be resolved with #7244.