Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement UI for using Files as open file dialog #6314

Open
gave92 opened this issue Oct 5, 2021 · 3 comments
Open

Feature: Implement UI for using Files as open file dialog #6314

gave92 opened this issue Oct 5, 2021 · 3 comments

Comments

@gave92
Copy link
Member

gave92 commented Oct 5, 2021

Requirements

  • Sidebar should be visible
  • Toolbar should be hidden
  • Tabs should be hidden
  • Address bar should be visible
  • There should be an open button
@gave92 gave92 changed the title Implement UI for using a Files as open file dialog Implement UI for using Files as open file dialog Oct 5, 2021
@yaira2 yaira2 removed their assignment Oct 14, 2022
@yaira2 yaira2 changed the title Implement UI for using Files as open file dialog Feature: Implement UI for using Files as open file dialog Oct 14, 2022
@0x5bfa
Copy link
Member

0x5bfa commented Apr 28, 2024

@gave92 We have another option to hide almost every detailed features - Compact Overlay.
While we have some dependency properties in AddressToolbar.xaml.cs and toggle these values in MainPage.xaml.cs, I think we should manage them in WindowContext to store application launch type: Default, CompactOverlay, SaveDialogOverride, OpenDialogOverride, then we can inject the context to each view model for controls and let them control visibilities.
What do you think this idea?

@gave92
Copy link
Member Author

gave92 commented Apr 30, 2024

Why not, though I haven't been on the project for some time and I'm not too familiar with WindowContext.
Another possibility is to create a specific MainPage and navigate to e.g. typeof(OpenFilePage) instead of MainPage.

@0x5bfa
Copy link
Member

0x5bfa commented Apr 30, 2024

That's also a good idea! We'd have to careful to the duplication of codebase.

@cinqmilleans implemented some global contexts that can be used everywhere with single instance using Depenendecy Injection (DI), which means you don't have to rely on view model or view codebehind context.
This enables us to reference many information, such as selected item in layout page or right clicked item in Sidebar or Widget and execute RichCommand (this is also a feature they implemented before, which also enables us to execute commands globally and manage commands via CommandManager using DI).

Since this means RichCommands (Files.App/Actions) rely on those contexts, we are planning to introduce argument (CommandParameter) not to rely and to enable to run truly globally.

Those contexts are somewhat similar to viewmodels of dedicated views but here's how looks:
Those information can be accessed globally
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Planning stage
Development

No branches or pull requests

3 participants