Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong translation of the deleted folder popup title in [it-IT] #8579

Closed
CapoFantasma97 opened this issue Mar 5, 2022 · 7 comments
Closed
Labels
bug Something isn't working 👀 needs - additional info Needs more information from the reporter

Comments

@CapoFantasma97
Copy link

Description

Using the Documents link in the Libraries section causes the prompt “Did you delete this folder” to appear systematically.
The folder however works correctly, once the popup is dismissed. It also does not appear when opening the Documents folder through other means (example: from the Favourites).
This only happens with the Documents folder, the Music and Video folders in the Libraries section do not have this issue.

immagine

Steps To Reproduce

  1. Go to the sidebar
  2. In the Libraries section, click on the Documents folder: the prompt appears
  3. In the Favourites section, clicking on the Documents folder does not show and anomaly

Expected behavior

The folder already works fine, yet somehow the app detects it as if it has been deleted or moved. Could it be a bug caused by a duplicate link? (Documents in Favourites and Documents in Libraries).

Files Version

Version: 2.1.15.0 OS Version: 10.0.22000.527

Windows Version

Windows 11 Home 21H2 Build 22000.527

Relevant Assets/Logs

debug.log
debug_fulltrust.log

@CapoFantasma97 CapoFantasma97 added the bug Something isn't working 👀 label Mar 5, 2022
@CapoFantasma97
Copy link
Author

CapoFantasma97 commented Mar 5, 2022

Also the Italian translation is flawed. It says:

Do you want to delete this folder?

But the English prompt says:

Did you delete this folder?

They ask very different things.

If the English version is the correct one (and given the context I highly believe it is) then it should be translated as:

Hai eliminato questa cartella?

immagine

@gave92
Copy link
Member

gave92 commented Mar 5, 2022

Try to right click on Documents Library in the sidebar > Properties > Library.
You'll see the list of folders that the library points to, some of them may be invalid or not accessible. If you remove them the popup should be gone.

@gave92
Copy link
Member

gave92 commented Mar 5, 2022

Tracking the popup issue in #6781. Tracking here the wrong translation issue.

@gave92 gave92 changed the title Interacting with the Documents folder causes a request of deletion popup to appear Wrong translation of the deleted folder popup title in [it-IT] Mar 5, 2022
@CapoFantasma97
Copy link
Author

Try to right click on Documents Library in the sidebar > Properties > Library. You'll see the list of folders that the library points to, some of them may be invalid or not accessible. If you remove them the popup should be gone.

I confirm that there was a (no longer valid) OneDrive folder included. I've removed it from the Documents library and it's now fixed.

@CapoFantasma97
Copy link
Author

Tracking the popup issue in #6781. Tracking here the wrong translation issue.

I can update the localization file when I have free time and create a pull request; I'll take the opportunity to proofread the other strings as well.

@yaira2
Copy link
Member

yaira2 commented May 11, 2022

@gave92 do you know if this is still an issue?

@yaira2 yaira2 added the needs - additional info Needs more information from the reporter label May 11, 2022
@gave92 gave92 closed this as completed May 12, 2022
@gave92
Copy link
Member

gave92 commented May 12, 2022

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👀 needs - additional info Needs more information from the reporter
Projects
None yet
Development

No branches or pull requests

3 participants