Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recent-files): make recent files not reverse itself when loaded #9153

Merged

Conversation

jiejasonliu
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Accessing an item from the MRU list via GetItem/GetFiles/etc while enumerating will update the access time

  • Add SuppressAccessTimeUpdate flag when getting item to avoid update

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)

before:
Files-5250-before


after:
Files-5250-after

@jiejasonliu
Copy link
Contributor Author

just a heads up, the MRU (most-recently-used) list does not update when accessing the files directly from Recent Files
did we want this behavior and if so, to what extent?

  1. accessing file does update MRU list but don't refresh UI (recent files widget)
  2. the above, but do refresh the UI

let me know if we want this to be included in this PR, if not i can include it in a different one.
i am aware that we are less concerned with new features for v2.3

@yaira2
Copy link
Member

yaira2 commented May 12, 2022

@jiejasonliu I think we can merge this as is and include it in v2.3, but it's good that you bring up MRU. We'd like to move away from this API and sync directly with the recent file list in File Explorer, is this something you would be interested in working on?

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 12, 2022
@yaira2 yaira2 merged commit 296646d into files-community:main May 12, 2022
@jiejasonliu
Copy link
Contributor Author

@yaichenbaum sure! i'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent files are incorrectly sorted when Files opens
2 participants