Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Removing expiry date for new transfer makes submission silently fail #1149

Closed
WebSpider opened this issue Oct 12, 2021 · 4 comments
Closed
Labels
fix merged A PR has been created and merged to help or address this issue

Comments

@WebSpider
Copy link
Collaborator

Description

When preparing a new transfer on filesender 2.30, the submit button becomes non-functional when the date field is empty.

How to reproduce

Start a new transfer. Select the date-picker screen. Do not select a date, but empty the field. Complete the other input fields for the new transfer. Press the submit button. The submission fails silently.

Possible fix

Add some kind of hint for the user what is missing for the submission of the new transfer to succeed

@monkeyiq
Copy link
Contributor

I guess we might also just make the date revert back to what it was if the user tries to empty the field.

@WebSpider
Copy link
Collaborator Author

That would work as well, if there is no valid date when the field loses focus, revert

@monkeyiq monkeyiq added the fix merged A PR has been created and merged to help or address this issue label Nov 20, 2021
@WebSpider WebSpider reopened this Mar 8, 2022
@WebSpider
Copy link
Collaborator Author

This is not fixed in 2.31

@monkeyiq
Copy link
Contributor

I see that the previous fix appeared to revert the value (on the upload page) but after the upload was complete the expires time was not set correctly looking in my transfers. The above #1289 should fix that.

@monkeyiq monkeyiq added fix merged A PR has been created and merged to help or address this issue and removed fix merged A PR has been created and merged to help or address this issue labels Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix merged A PR has been created and merged to help or address this issue
Projects
None yet
Development

No branches or pull requests

2 participants