Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI3: Code details - Default settings changes #1650

Open
WebSpider opened this issue Nov 2, 2023 · 2 comments
Open

UI3: Code details - Default settings changes #1650

WebSpider opened this issue Nov 2, 2023 · 2 comments
Assignees
Labels
blocking must be fixed before release release3.0 Related to releasing 3.0 UI User interface update

Comments

@WebSpider
Copy link
Collaborator

ConfigDefaults.php
(code3) Default settings should be preserved unless that board approves them.
Exceptions: options relating to transfer settings might be moved to advanced
adding terms to allow_pages_core seems ok
adding new transfer detail and other pages to add_for_user

@WebSpider WebSpider added UI User interface update release3.0 Related to releasing 3.0 labels Nov 2, 2023
@WebSpider
Copy link
Collaborator Author

The following settings have been changed with the introduction of UIv3:

'lang_userpref_enabled' => from default false to default true
'lang_url_enabled' => from default false to default true
'lang_selector_enabled' => from default false to default true
'lang_save_url_switch_in_userpref' => from default false to default true
'upload_display_bits_per_sec' => from default false to default true
'upload_display_per_file_stats' => from default false to default true
'admin_can_view_user_transfers_page' => from default false to default true
'allow_pages_core' => Page with TERMS has been added
'allow_pages_add_for_user' => Following pages were added:
GUIPages::TRANSFER_DETAIL, GUIPages::NEW_INVITATION, GUIPages::INVITATION_DETAIL,

The following transfer options have been moved to the advanced options and now need an extra click to be visible, when enabled:
'email_me_on_expire'
'email_download_complete'
'email_report_on_closing'
'email_recipient_when_transfer_expires'
'add_me_to_recipients'
'get_a_link'
'must_be_logged_in_to_download'

The following guest options have been moved to the advanced options and now need an extra click to be visible, when enabled:
'email_upload_started'
'email_upload_page_access'
'can_only_send_to_me'

@WebSpider
Copy link
Collaborator Author

First thoughts:

  1. I understand language switching to be on as a new default. The technique is mature and pretty well implemented in FileSender. We should see if most stakeholders agree on this
  2. I don't see why the upload_display format should be changed, this seems more like a personal preference
  3. The ability for the admin to view user transfers has not changed in sensitivity, we should probably keep the same default as it was before
  4. Page changes are logical for the function they serve
  5. The majority of changes in transfer/guest options make sense, since the new design calls for less buttons in general, so the enduser has clearer choices. One exception: get_a_link should probably not change, as we in general want to promote lower amounts of email being sent by FileSender installs.

@WebSpider WebSpider self-assigned this Nov 30, 2023
@WebSpider WebSpider added the blocking must be fixed before release label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking must be fixed before release release3.0 Related to releasing 3.0 UI User interface update
Projects
None yet
Development

No branches or pull requests

1 participant