-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI3: Selecting a transfer link opens up the e-mail detail screen #1920
Comments
That confused me as well but this is not an "email dialog", otherwise it would be missing the all-essential input fieled for email addresses. And the information entered there actually shows up on the web page the recipient uses to download the transfer. While the implementation (or UI) may have been re-used from the email option I think this part of the UI would be more understandable if the |
Oh wow, now I see. I really wonder how that got there, and what purpose it serves.
Agreed. Personally, I don't see any use for this at all, but there may be some installs that are looking for something like this. |
I imagined that in UI/UX land having subject and message on both paths was more user friendly. It has been there since last year. |
Perhaps we should have the UI experts chime in on this change. I have opened a governance ticket for this filesender/governance#40 |
I'm in favour of simply hiding subject+message for get-a-link (keep things simple) |
It may be the case that the march updates such as "Fix/resume transfer" are intended as the final contributions to the ui3. |
On filesender 3.0 b7
The email detail dialog is opened. This does not make any sense, since the user specifically chooses not to send an e-mail and confuses our test-users
![Screenshot from 2024-06-07 12-26-42](https://private-user-images.githubusercontent.com/437323/337622776-1239f79c-800a-43ff-8826-3b11d9afcc0d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0NDMzNTYsIm5iZiI6MTcyMTQ0MzA1NiwicGF0aCI6Ii80MzczMjMvMzM3NjIyNzc2LTEyMzlmNzljLTgwMGEtNDNmZi04ODI2LTNiMTFkOWFmY2MwZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyMFQwMjM3MzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jZDBiMzU3YWI3NjIxYzQwMzA2YTJhNTQzMWQzM2ZkOTgyMzhmOTBlYWZjNGVhYmE2MjU0MjhhYzMzMmQ0MGZhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.jECkBNfBHo6csoWMdbnaT1uw6ZNs3Su6ZHTzCxU52kM)
Suggested fix
Only unfold the e-mail dialog when the user chooses e-mail as transfer method, and refold it if the user chooses the transfer link
The text was updated successfully, but these errors were encountered: