Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voucher actions incorrect icons #1922

Closed
monkeyiq opened this issue Jun 10, 2024 · 3 comments
Closed

Voucher actions incorrect icons #1922

monkeyiq opened this issue Jun 10, 2024 · 3 comments
Assignees
Labels
fix merged A PR has been created and merged to help or address this issue release3.0 Related to releasing 3.0 UI User interface update

Comments

@monkeyiq
Copy link
Contributor

This was reported to me privately. I am opening a github issue for full transparency since I will likely work on an update for this issue it is useful for the community to see the history. I have modified the wording slightly in the below.

...On the Vouchers page, the icons for resend voucher and send a reminder are different on FileSender V3 compared to the current version [release 2.x series].

The current version of FileSender uses:

  • the refresh icon ⟶ reminder action
  • an envelope icon ⟶ add a recipient

FileSender V3 has

  • forward icon ⟶ reminder
  • refresh icon ⟶ send to new email address.

Also, can we update the text on the ‘resender voucher’ to be ‘Add a recipient’ as we have on the current version. How it is now is confusing with ‘Send a reminder’ and ‘resend voucher’ as they both sound like they do the same thing.

Ideally, it should be

  • Refresh icon ⟶ Send reminder
  • Envelope icon ⟶ Add recipient
  • Bin icon ⟶ Delete voucher

This is also the same on the voucher detail page, so needs to be updated the same way.

@monkeyiq monkeyiq added UI User interface update release3.0 Related to releasing 3.0 labels Jun 10, 2024
@monkeyiq
Copy link
Contributor Author

I am not sure why resend voucher was changed to the non english friendly "resender voucher".

@monkeyiq monkeyiq self-assigned this Jun 10, 2024
@monkeyiq
Copy link
Contributor Author

If RNP wants to jump in here I am happy to hand over ownership of the issue. I have taken it by default.

@madsi1m
Copy link
Contributor

madsi1m commented Jun 14, 2024

#1933

@monkeyiq monkeyiq added the fix merged A PR has been created and merged to help or address this issue label Jun 14, 2024
@madsi1m madsi1m closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix merged A PR has been created and merged to help or address this issue release3.0 Related to releasing 3.0 UI User interface update
Projects
None yet
Development

No branches or pull requests

2 participants