Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uploading of InputStreams #50

Closed
shawnmaten opened this issue Jan 5, 2018 · 0 comments
Closed

Support uploading of InputStreams #50

shawnmaten opened this issue Jan 5, 2018 · 0 comments
Assignees
Milestone

Comments

@shawnmaten
Copy link
Contributor

We need to be able to upload from InputStream objects so that we can properly support local uploads in Android. This will require refactoring the Upload* classes a bit. I think the main issue will just be rethinking how we divide the work between multiple workers. Right now we assign a (worker / thread / observable) a section of a file to read and upload. Instead we should have multiple workers that independently read and upload from a shared InputStream. That reading will have to be synchronized, but otherwise I don't think this will be too much of a problem. To keep support of uploading with a file system path, and not overcomplicate things, we should just convert file system paths to InputStreams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant