Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCS computation crosses key boundaries. #67

Open
cmeiklejohn opened this issue Feb 21, 2023 · 1 comment
Open

LCS computation crosses key boundaries. #67

cmeiklejohn opened this issue Feb 21, 2023 · 1 comment
Labels
advanced help wanted Extra attention is needed

Comments

@cmeiklejohn
Copy link
Contributor

LCS algorithm used in the ResponseBecomesRequest analyzer considers field names. The LCS should be restricted in such a way that it only considers the values for each key. Therefore, something should basically truncate/stop the LCS if it sees either (A) end of line, indicating that we're moving to a new field or (B) colon, which is used to separate key from value.
@cmeiklejohn cmeiklejohn changed the title LCS computation considers field names. LCS computation crosses key boundaries. Feb 21, 2023
@cmeiklejohn
Copy link
Contributor Author

probably would be easier if we recorded the actual GeneratedMessageV3's

@cmeiklejohn cmeiklejohn added help wanted Extra attention is needed advanced labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
advanced help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmeiklejohn @peteryongzhong