Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect data nondeterminism and warn in both the log and UX #76

Open
cmeiklejohn opened this issue Mar 13, 2023 · 1 comment
Open

Detect data nondeterminism and warn in both the log and UX #76

cmeiklejohn opened this issue Mar 13, 2023 · 1 comment
Assignees

Comments

@cmeiklejohn
Copy link
Contributor

Right now, if you write a test where the RPC messages are susceptible to data nondeterminism, when we try to inject a fault for those RPCs, we will not actually inject the fault. To solve the problem, the developer needs to set the dataNondeterminism = true option in the test annotation which alters the search algorithm to deal with this.

However, developers using Filibuster may be unaware that their code contains data nondeterminism. Therefore, we should warn the developer if we tried to inject faults that we couldn't. Right now, in the test reporting there is some code that finds places where the RPCs we tried to inject faults on doesn't match the RPCs we observed in the exception. We should use this information to warn the developer about this and recommend that the data nondeterminism option is used.

@cmeiklejohn
Copy link
Contributor Author

Let's resurrect this one. Can we talk about how to proceed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants