Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for URDNA2015? #84

Closed
peacekeeper opened this issue Oct 7, 2020 · 7 comments
Closed

Support for URDNA2015? #84

peacekeeper opened this issue Oct 7, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@peacekeeper
Copy link

Is anyone working on adding support for the URDNA2015 RDF Dataset Normalization algorithm?

jsonld-java supports URGNA2012, but that's outdated...

@filip26
Copy link
Owner

filip26 commented Oct 7, 2020

Hi, please feel free to open PR.

@filip26 filip26 added the enhancement New feature or request label Oct 8, 2020
@simon-greatrix
Copy link
Contributor

I have an implementation of URDNA2015:

https://github.com/simon-greatrix/rdf-urdna

@peacekeeper
Copy link
Author

@simon-greatrix great, are you planning to release this under Apache 2 license and/or merge it into this project here?

@simon-greatrix
Copy link
Contributor

@peacekeeper I have requested permission to release it under Apache 2 license from my employers and expect to hear back about it today.

@filip26 It's obviously your call as to whether you see normalization as something that should be included in Titanium. I would suggest adding an appropriate method to the "Rdf" and "RdfProvider" classes?

@filip26
Copy link
Owner

filip26 commented Oct 13, 2020

Hi @simon-greatrix,
URDNA is a complementary technology to JSON-LD, not needed to perform JSON-LD algorithms nor required by every user. It's a great extension that should be distributed as a standalone library.

Titanium is an open project and welcomes a contribution. Your implementation could be included as an extension (root project directory refactoring is needed) if:

  • Licensing, intellectual property ownership, of your code is resolved. As far as I understand your employer holds IP and it would be unfortunate to put whole Titanium code at risk in a case of unresolved relations
  • You plan to contribute to Titanium in the future and you are willing to maintain URDNA code

Anyway, you make me realize that it would be great to have a list of projects using and extending Titanium as part of the project's README.

@simon-greatrix
Copy link
Contributor

@peacekeeper My employers decided to debate our entire open source strategy so it took a lot longer than expected. I have now released my URDNA implementation under Apache 2.

For the time being, I will be maintaining it as a separate library rather than as part of Titanium.

@peacekeeper
Copy link
Author

@simon-greatrix thanks a lot! I also did my own implementation just a few days before you mentioned yours: https://github.com/decentralized-identity/jsonld-common-java/tree/master/src/main/java/foundation/identity/jsonld/normalization

But I think I will use yours going forward. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants