Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] twice in addons preview #33

Closed
B0pol opened this issue Sep 3, 2020 · 2 comments
Closed

[Mobile] twice in addons preview #33

B0pol opened this issue Sep 3, 2020 · 2 comments

Comments

@B0pol
Copy link

B0pol commented Sep 3, 2020

(Using iceweasel https://github.com/interfect/fenix)

Why is it twice in addons? Is it a bug or intentional? It is disturbing and think you should be there only once

@FilipePS
Copy link
Owner

FilipePS commented Sep 3, 2020

It's not exactly a bug, but I'll fix it.
If you want to know details:
Before, the extension just had an icon in the address bar (pageAction), which did not appear for Firefox Mobile because it would be strange to see an icon to translate all the time.
Recently resolving to change the translate button for the toolbar (browserAction), which was very good for Firefox Mobile, has generated several complaints for those who use Firefox Desktop. So decide to leave them both, and whoever didn't want 1 of them just had to hide it manually.
Now in this Firefox Fenix, the menu is showing both pageAction and browserAction.
The browserAction cannot be hidden, whether it exists or not. the pageAction can be hidden.

Now that pageAction appears in the Firefox Fenix Menu, I'm going to remove browserAction.

@FilipePS
Copy link
Owner

FilipePS commented Sep 6, 2020

355ef23

@FilipePS FilipePS closed this as completed Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants