-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip patterns are ignored for external links #27
Comments
I have the same issue, how do we deal with links like these? linkchecker tries to find #!forum/flutter-dev anchor. I tried encoding the url: https://groups.google.com/forum/%23%21forum/fastai-diff but google doesn't decode the # part, only the !-part. hash-bang has been deprecated for a while now: https://www.w3.org/blog/2011/05/hash-uris/ but google groups doesn't get updated :( I used the domain instead to fix it. My current skip-urls file:
|
Sorry for the late reply to this. This seems to work for me. I've added a test case (0b7a581) and it passes (https://travis-ci.org/filiph/linkcheck/builds/450432074). One thing to note is that the lines in the skip file are all regexp. That means that if you want to skip a If this resolves your issue, I'll treat this as a documentation bug. |
Thanks for looking into this @filiph. I'll give it another try soon. (As for |
Strange, the same skip pattern indeed seems to be working now! |
For example, the following skip pattern:
seems to be ignored for the external link
https://groups.google.com/forum/#!forum/flutter-dev
:cc @Sfshaza
The text was updated successfully, but these errors were encountered: